Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16258#discussion_r92077840
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/streaming/progress.scala ---
    @@ -33,27 +34,6 @@ import org.apache.spark.sql.catalyst.util.DateTimeUtils
     
     /**
      * :: Experimental ::
    - * Information about updates made to stateful operators in a 
[[StreamingQuery]] during a trigger.
    --- End diff --
    
    Thats actually the opposite of how most code in SQL is laid out, so I think 
it would be better to avoid this change.  The logic here is declarations that 
are use later should come first (references before declaration make it harder 
to read), and stuff at the end of the file is kind of hidden.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to