Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/16290#discussion_r92873918
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -964,11 +970,17 @@ object StaticSQLConf {
}
}
- val WAREHOUSE_PATH = buildConf("spark.sql.warehouse.dir")
- .doc("The default location for managed databases and tables.")
+ val DEFAULT_WAREHOUSE_PATH = buildConf("spark.sql.default.warehouse.dir")
+ .doc("The default location for managed databases and tables. " +
+ "Used if spark.sql.warehouse.dir is not set")
.stringConf
.createWithDefault(Utils.resolveURI("spark-warehouse").toString)
+ val WAREHOUSE_PATH = buildConf("spark.sql.warehouse.dir")
+ .doc("The location for managed databases and tables.")
--- End diff --
Thats a good point. I misunderstood the meaning of `default` there. Will
fix this now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
