Github user bdwyer2 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16290#discussion_r92916155
--- Diff: R/pkg/inst/tests/testthat/test_context.R ---
@@ -72,6 +72,20 @@ test_that("repeatedly starting and stopping
SparkSession", {
}
})
+test_that("Default warehouse dir should be set to tempdir", {
+ sparkR.session.stop()
+ sparkR.session(enableHiveSupport = FALSE)
+
+ # Create a temporary table
+ sql("CREATE TABLE people_warehouse_test")
+ # spark-warehouse should be written only tempdir() and not current
working directory
+ res <- list.files(path = ".", pattern = ".*spark-warehouse.*",
--- End diff --
should we test to make sure that no files are created during this process
instead of only checking for `spark-warehouse`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
