Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1717#discussion_r17202369
  
    --- Diff: 
external/twitter/src/main/scala/org/apache/spark/streaming/twitter/TwitterInputDStream.scala
 ---
    @@ -42,9 +44,19 @@ class TwitterInputDStream(
         @transient ssc_ : StreamingContext,
         twitterAuth: Option[Authorization],
         filters: Seq[String],
    +    locations: Seq[Seq[Double]],
         storageLevel: StorageLevel
       ) extends ReceiverInputDStream[Status](ssc_)  {
     
    +  def this(
    --- End diff --
    
    Actually, no need to create two constructors. Since this is a non-public 
class internal to Spark, we dont need to maintain binary compatibility. So one 
common constructor is fine enough.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to