Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1717#discussion_r17205863
--- Diff:
external/twitter/src/main/scala/org/apache/spark/streaming/twitter/TwitterUtils.scala
---
@@ -33,15 +33,20 @@ object TwitterUtils {
* twitter4j.oauth.consumerSecret, twitter4j.oauth.accessToken and
* twitter4j.oauth.accessTokenSecret
* @param filters Set of filter strings to get only those tweets that
match them
+ * @param locations Set of longitude and latitude coordinates to get
only those tweets within the
+ bounding box defined by those points. Example:
Seq(Seq(-180.0,-90.0),Seq(180.0,90.0))
+ gives any geotagged tweet. If locations and filters are both
nonempty, then any tweet
+ matching either condition may be returned.
* @param storageLevel Storage level to use for storing the received
objects
*/
def createStream(
ssc: StreamingContext,
twitterAuth: Option[Authorization],
filters: Seq[String] = Nil,
+ locations: Seq[Seq[Double]] = Nil,
--- End diff --
I didnt get you, why are you adding this this method? This does not have
the locations. Instead isnt it better to keep the existing function as is and
add
```
def createStream(
ssc: StreamingContext,
twitterAuth: Option[Authorization],
filters: Seq[String],
locations: Seq[String],
storageLevel: StorageLevel
): ReceiverInputDStream[Status] = {
createStream(ssc, twitterAuth, filters, Nil, storageLevel)
}
```
Also worth remember that Scala does not allow two overloaded functions to
have default params. That would give compiler errors.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
