Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16308#discussion_r92915771
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
 ---
    @@ -120,7 +128,10 @@ object Cast {
           > SELECT _FUNC_('10' as int);
            10
       """)
    -case class Cast(child: Expression, dataType: DataType) extends 
UnaryExpression with NullIntolerant {
    +case class Cast(child: Expression, dataType: DataType, zoneId: String = 
null)
    --- End diff --
    
    not 100% sure whether this is a good idea, but should we consider adding a 
Cast.unapply that does not match on zoneId?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to