Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r92916070
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -30,21 +30,44 @@ import org.apache.spark.sql.types._
import org.apache.spark.unsafe.types.{CalendarInterval, UTF8String}
/**
+ * Common base class for time zone aware expressions.
+ */
+trait TimeZoneAwareExpression extends Expression {
+
+ def zoneId: String
+
+ def timeZoneResolved: Boolean = zoneId != null
+
+ def withTimeZone(zoneId: String): TimeZoneAwareExpression
+
+ def timeZone: TimeZone = TimeZone.getTimeZone(zoneId)
--- End diff --
should this be a lazy val? otherwise it is pretty expensive to keep
creating a new timezone object per row in the interpreted path.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
