Github user brkyvz commented on a diff in the pull request:
https://github.com/apache/spark/pull/16282#discussion_r93331357
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSource.scala
---
@@ -536,11 +570,12 @@ private[kafka010] object KafkaSource {
override def toString: String = s"Subscribe[${topics.mkString(", ")}]"
}
- case class SubscribePatternStrategy(
- topicPattern: String, kafkaParams: ju.Map[String, Object])
+ case class SubscribePatternStrategy(topicPattern: String)
extends ConsumerStrategy {
- override def createConsumer(): Consumer[Array[Byte], Array[Byte]] = {
- val consumer = new KafkaConsumer[Array[Byte],
Array[Byte]](kafkaParams)
+ override def createConsumer(
+ kafkaParams: ju.Map[String, Object]): Consumer[Array[Byte],
Array[Byte]] = {
+ val consumer =
+ new KafkaConsumer[Array[Byte], Array[Byte]](kafkaParams)
--- End diff --
nit: move to line above
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
