Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16282#discussion_r93355639
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSource.scala
---
@@ -511,12 +537,20 @@ private[kafka010] object KafkaSource {
))
sealed trait ConsumerStrategy {
- def createConsumer(): Consumer[Array[Byte], Array[Byte]]
+ def createConsumer(kafkaParams: ju.Map[String, Object]):
Consumer[Array[Byte], Array[Byte]]
+
+ def newKafkaParams(
+ kafkaParams: ju.Map[String, Object],
+ groupId: String): ju.Map[String, Object] = {
+ val newKafkaParams = new ju.HashMap[String, Object](kafkaParams)
--- End diff --
Nit: please dont reuse the name of the function as a variable. its
confusing while reading code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
