Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/16344
@srowen @yanboliang Thanks much for the feedback. I now have a better
understanding of the code and the issue. I have made new commits reflecting
your suggestions. The major changes are summarized below:
- Create new method `fromModel` in the `Family` object to get the desired
family object by accessing the `GeneralizedLinearRegressionBase` object
directly. This solves the main challenge of setting the variancePower of the
Tweedie family. The old `fromName` method is deleted since we now need both
`name` and `variancePower`.
- Create `TweedieFamily` as new subclass of `family`. This class
encompasses the special cases of Gaussian, Poisson and Gamma, which can be
handled together using the general formula based on variancePower.
Please let me know if there are any other issues. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
