Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/16344
@srowen Thanks for the comments. Makes lots of sense to move the switch to
subclass. I did not know one could override a `val`.
In the new commit, I have moved the `defaultLink` and `aic` to subclasses.
I also added back `name` in the constructor. The other methods `initialize`,
`variance`, `deviance` and `project` are common and thus implemented in the
`TweedieFamily` parent class. Hope this makes sense.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
