Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15212#discussion_r93725546
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/ChiSqSelector.scala ---
@@ -92,8 +92,36 @@ private[feature] trait ChiSqSelectorParams extends Params
def getFpr: Double = $(fpr)
/**
+ * The highest uncorrected p-value for features to be kept.
--- End diff --
I think the doc is incorrect even it's consistent with sklearn, actually we
don't compare ```fdr``` value with ```p-value``` directly. I'm more prefer to
change as ```The upper bound of the expected false discovery rate``` which is
more accuracy and easy to understand.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
