Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15212#discussion_r93726001
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/ChiSqSelector.scala ---
@@ -92,8 +92,36 @@ private[feature] trait ChiSqSelectorParams extends Params
def getFpr: Double = $(fpr)
/**
+ * The highest uncorrected p-value for features to be kept.
+ * Only applicable when selectorType = "fdr".
+ * Default value is 0.05.
+ * @group param
+ */
+ @Since("2.1.0")
+ final val fdr = new DoubleParam(this, "fdr",
+ "The highest uncorrected p-value for features to be kept.",
ParamValidators.inRange(0, 1))
+ setDefault(fdr -> 0.05)
+
+ /** @group getParam */
+ def getFdr: Double = $(fdr)
+
+ /**
+ * The highest uncorrected p-value for features to be kept.
--- End diff --
Ditto, ```The upper bound of the expected family-wise error rate```.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
