Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93778762
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -303,14 +341,15 @@ object GeneralizedLinearRegression extends
DefaultParamsReadable[GeneralizedLine
/** Set of family and link pairs that GeneralizedLinearRegression
supports. */
private[regression] lazy val supportedFamilyAndLinkPairs = Set(
- Gaussian -> Identity, Gaussian -> Log, Gaussian -> Inverse,
- Binomial -> Logit, Binomial -> Probit, Binomial -> CLogLog,
- Poisson -> Log, Poisson -> Identity, Poisson -> Sqrt,
- Gamma -> Inverse, Gamma -> Identity, Gamma -> Log
+ "gaussian" -> Identity, "gaussian" -> Log, "gaussian" -> Inverse,
--- End diff --
Yeah, you are right. It needs an extra global object to avoid error-prone
which may a little expensive. I'm ok with using string.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
