Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93774215
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -397,46 +434,118 @@ object GeneralizedLinearRegression extends
DefaultParamsReadable[GeneralizedLine
/** Trim the fitted value so that it will be in valid range. */
def project(mu: Double): Double = mu
+
}
private[regression] object Family {
/**
- * Gets the [[Family]] object from its name.
+ * Gets the [[Family]] object based on family and variancePower.
+ * 1) retrieve object based on family name
+ * 2) if family name is tweedie, retrieve object based on variancePower
*
- * @param name family name: "gaussian", "binomial", "poisson" or
"gamma".
+ * @param model a GenerealizedLinearRegressionBase object
*/
- def fromName(name: String): Family = {
- name match {
- case Gaussian.name => Gaussian
- case Binomial.name => Binomial
- case Poisson.name => Poisson
- case Gamma.name => Gamma
+ def fromModel(model: GeneralizedLinearRegressionBase): Family = {
--- End diff --
Rename to ```fromParams```, we extract ```family``` and ```variancePower```
from the ```Params``` which is the superclass of GLR estimator and model. And
actually we use this function for both estimator(L279) and model(L974).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
