Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16391#discussion_r93844973
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DatasetBenchmark.scala ---
@@ -170,36 +176,39 @@ object DatasetBenchmark {
val benchmark3 = aggregate(spark, numRows)
/*
- OpenJDK 64-Bit Server VM 1.8.0_91-b14 on Linux
3.10.0-327.18.2.el7.x86_64
- Intel Xeon E3-12xx v2 (Ivy Bridge)
+ Java HotSpot(TM) 64-Bit Server VM 1.8.0_60-b27 on Mac OS X 10.12.1
+ Intel(R) Core(TM) i7-4960HQ CPU @ 2.60GHz
+
back-to-back map: Best/Avg Time(ms)
Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------
- RDD 3448 / 3646 29.0
34.5 1.0X
- DataFrame 2647 / 3116 37.8
26.5 1.3X
- Dataset 4781 / 5155 20.9
47.8 0.7X
+ RDD 3963 / 3976 25.2
39.6 1.0X
+ DataFrame 826 / 834 121.1
8.3 4.8X
+ Dataset 5178 / 5198 19.3
51.8 0.8X
--- End diff --
ah, scala compiler is smart! I think we can create a ticket to optimize
this, i.e. call the primitive apply version, and update the benchmark result.
For byte code analysis, let's discuss about it in the ticket later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
