Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16460#discussion_r94528412
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InsertIntoHadoopFsRelationCommand.scala
---
@@ -74,12 +69,29 @@ case class InsertIntoHadoopFsRelationCommand(
val fs = outputPath.getFileSystem(hadoopConf)
val qualifiedOutputPath = outputPath.makeQualified(fs.getUri,
fs.getWorkingDirectory)
+ val partitionsTrackedByCatalog = catalogTable.isDefined &&
+ catalogTable.get.partitionColumnNames.nonEmpty &&
+ catalogTable.get.tracksPartitionsInCatalog
--- End diff --
This is something I wanna check with @ericl . What if users create a table
with partition management, then turn it off, and read this table? If we treat
this table as normal table, then the data in custom partition path will be
ignored.
I think we should respect the partition management flag when the table was
created, not when the table is read.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
