Github user ericl commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16460#discussion_r94536423
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InsertIntoHadoopFsRelationCommand.scala
 ---
    @@ -74,12 +69,29 @@ case class InsertIntoHadoopFsRelationCommand(
         val fs = outputPath.getFileSystem(hadoopConf)
         val qualifiedOutputPath = outputPath.makeQualified(fs.getUri, 
fs.getWorkingDirectory)
     
    +    val partitionsTrackedByCatalog = catalogTable.isDefined &&
    +      catalogTable.get.partitionColumnNames.nonEmpty &&
    +      catalogTable.get.tracksPartitionsInCatalog
    --- End diff --
    
    Hm, in other parts of the code we assume that the feature is completely 
disabled when the flag is off. This is probably needed since there is no way to 
revert a table otherwise.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to