Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16451#discussion_r94932941
--- Diff:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaTestUtils.scala
---
@@ -138,10 +139,15 @@ class KafkaTestUtils extends Logging {
if (server != null) {
server.shutdown()
+ server.awaitShutdown()
server = null
}
- brokerConf.logDirs.foreach { f => Utils.deleteRecursively(new File(f))
}
+ // On Windows, `logDirs` is left open even after Kafka server above is
completely shut-downed
+ // in some cases. It leads to test failures on Windows if these are
not ignored.
+ brokerConf.logDirs.map(new File(_))
+ .filterNot(FileUtils.deleteQuietly)
--- End diff --
I think I missed the point here, sorry: so, why do we think that
FileUtils.deleteQuietly works but Utils.deleteRecursively does not? Is the
point just that the former method is "quiet" instead of throwing an exception?
I suppose I'd just try-catch around the Utils.deleteRecursively instead of use
a different method in this case. Either way you have a path that logs a
statement here so it's not so different either way.
I don't feel too strongly about it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
