Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1360#discussion_r17250396
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala 
---
    @@ -295,28 +295,34 @@ private[spark] class Master(
           val execOption = idToApp.get(appId).flatMap(app => 
app.executors.get(execId))
           execOption match {
             case Some(exec) => {
    +          val appInfo = idToApp(appId)
    --- End diff --
    
    This will crash if `idToApp` doesn't already contain `appId`. Maybe we 
should log a warning instead of throwing a key not found exception.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to