Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/1360#discussion_r17254222
--- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala
---
@@ -295,28 +295,34 @@ private[spark] class Master(
val execOption = idToApp.get(appId).flatMap(app =>
app.executors.get(execId))
execOption match {
case Some(exec) => {
+ val appInfo = idToApp(appId)
exec.state = state
+ if (state == ExecutorState.RUNNING) { appInfo.resetRetryCount() }
exec.application.driver ! ExecutorUpdated(execId, state,
message, exitStatus)
if (ExecutorState.isFinished(state)) {
- val appInfo = idToApp(appId)
// Remove this executor from the worker and app
- logInfo("Removing executor " + exec.fullId + " because it is "
+ state)
+ logInfo(s"Removing executor ${exec.fullId} because it is
$state")
appInfo.removeExecutor(exec)
exec.worker.removeExecutor(exec)
- val normalExit = exitStatus.exists(_ == 0)
+ val normalExit = exitStatus == Some(0)
--- End diff --
Just seemed even clearer to directly compare Options instead of using a HOF.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
