Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16487#discussion_r95298747
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -385,6 +380,8 @@ final class DataFrameWriter[T] private[sql](ds:
Dataset[T]) {
}
EliminateSubqueryAliases(catalog.lookupRelation(tableIdentWithDB))
match {
// Only do the check if the table is a data source table (the
relation is a BaseRelation).
+ // TODO(cloud-fan): also check hive table relation here when we
support overwrite mode
+ // for creating hive tables.
--- End diff --
Although we ignore the specified provider, we still respect the actual
format of the table. For example, below is the Hive table. We are not blocking
it. Should we block it to make them consistent?
```Scala
sql(s"CREATE TABLE $tableName STORED AS SEQUENCEFILE AS SELECT 1 AS
key, 'abc' AS value")
val df = sql(s"SELECT key, value FROM $tableName")
df.write.mode("overwrite").insertInto(tableName)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
