Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16487#discussion_r95298994
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -385,6 +380,8 @@ final class DataFrameWriter[T] private[sql](ds:
Dataset[T]) {
}
EliminateSubqueryAliases(catalog.lookupRelation(tableIdentWithDB))
match {
// Only do the check if the table is a data source table (the
relation is a BaseRelation).
+ // TODO(cloud-fan): also check hive table relation here when we
support overwrite mode
+ // for creating hive tables.
--- End diff --
We should not block it. This generates `InsertIntoTable`, and it supports
hive table. What we should block is `saveAsTable` with `Overwrite` mode, which
generates `CreateTable`.
`insert overwrite` is different from `create table with overwrite mode`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
