Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16387#discussion_r95458142
--- Diff:
core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala
---
@@ -192,12 +193,16 @@ class ExternalAppendOnlyMap[K, V, C](
* It will be called by TaskMemoryManager when there is not enough
memory for the task.
*/
override protected[this] def forceSpill(): Boolean = {
- assert(readingIterator != null)
- val isSpilled = readingIterator.spill()
- if (isSpilled) {
- currentMap = null
+ if (isReadingIterator) {
+ assert(readingIterator != null)
+ val isSpilled = readingIterator.spill()
+ if (isSpilled) {
+ currentMap = null
+ }
+ isSpilled
+ } else {
+ false
--- End diff --
This fixes the problem reported in the bug, but is there a reason not to
just instantiate `readingIterator` if it hasn't been set yet? Feels like it
would be the right thing to do.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
