Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16387#discussion_r95501216
--- Diff:
core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala
---
@@ -192,12 +193,16 @@ class ExternalAppendOnlyMap[K, V, C](
* It will be called by TaskMemoryManager when there is not enough
memory for the task.
*/
override protected[this] def forceSpill(): Boolean = {
- assert(readingIterator != null)
- val isSpilled = readingIterator.spill()
- if (isSpilled) {
- currentMap = null
+ if (isReadingIterator) {
+ assert(readingIterator != null)
+ val isSpilled = readingIterator.spill()
+ if (isSpilled) {
+ currentMap = null
+ }
+ isSpilled
+ } else {
+ false
--- End diff --
As I commented before:
> I choose to simply return false now. Another option is to actually spill
the in-memory map.
If `readingIterator` is not set, once `forceSpill` is called we can spill
the content of `currentMap` into disk like `spill` does now.
We can't just instantiate `readingIterator` and spill it. Because
`readingIterator` is only created for iterating over the entries of the
in-memory map, when we want to read the content of this
`ExternalAppendOnlyMap`. If `forceSpill` is called before we want to read the
content, and we instantiate `readingIterator` and spill it, the in-memory map
will be released and we can't insert data further.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
