Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/16554#discussion_r95702064
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetIOSuite.scala
---
@@ -462,16 +463,19 @@ class ParquetIOSuite extends QueryTest with
ParquetTest with SharedSQLContext {
}
test("SPARK-8121: spark.sql.parquet.output.committer.class shouldn't be
overridden") {
- val extraOptions = Map(
- SQLConf.OUTPUT_COMMITTER_CLASS.key ->
classOf[ParquetOutputCommitter].getCanonicalName,
- "spark.sql.parquet.output.committer.class" ->
- classOf[JobCommitFailureParquetOutputCommitter].getCanonicalName
- )
- withTempPath { dir =>
- val message = intercept[SparkException] {
- spark.range(0,
1).write.options(extraOptions).parquet(dir.getCanonicalPath)
- }.getCause.getMessage
- assert(message === "Intentional exception for testing purposes")
+ withSQLConf(SQLConf.FILE_COMMIT_PROTOCOL_CLASS.key ->
+ classOf[SQLHadoopMapReduceCommitProtocol].getCanonicalName) {
--- End diff --
Here and below, the tests were indented verbatim.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
