Github user ericl commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16554#discussion_r95704748
  
    --- Diff: 
core/src/main/scala/org/apache/spark/internal/io/FileCommitProtocol.scala ---
    @@ -112,6 +113,15 @@ abstract class FileCommitProtocol {
        * just crashes (or killed) before it can call abort.
        */
       def abortTask(taskContext: TaskAttemptContext): Unit
    +
    +  /**
    +   * Specifies that a file should be deleted with the commit of this job. 
The default
    +   * implementation deletes the file immediately, but this may be 
overriden to delay the physical
    +   * deletion of the file until commit time.
    --- End diff --
    
    Yeah I guess that's implementation-specific. Removed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to