Github user marmbrus commented on the pull request:

    https://github.com/apache/spark/pull/2230#issuecomment-54900963
  
    Hmm, does Hive support using dot notation to access fields that are 
arbitrarily nested in arrays?  If not I think it would be better to just 
support one level.  Also, the code added for that feature uses a lot of mutable 
state and is a little hard to follow (in addition to removing the type check).
    
    Since I'd really like to include your parser fixes and test cleanup, what 
do you think about breaking out the GetField on arrays change into another PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to