Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2230#issuecomment-54252034
Thanks for working on this! The changes made to the parser seem reasonable
to me. Thanks for the thorough explanation.
Can you explain your changes to LogicalPlan a little more and add some
inline comments. Thats a very crucial piece of code and I'm a little nervous
about changing it. Also it seems like we might be missing the distinct logic
based on the failing test case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
