Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2226#discussion_r17277137
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala
 ---
    @@ -178,6 +253,40 @@ case class InsertIntoHiveTable(
         val tableLocation = table.hiveQlTable.getDataLocation
         val tmpLocation = hiveContext.getExternalTmpFileURI(tableLocation)
         val fileSinkConf = new FileSinkDesc(tmpLocation.toString, tableDesc, 
false)
    +    var tmpDynamicPartNum = 0
    +    var numStaPart = 0
    --- End diff --
    
    Instead of using `vars` here can this just be?
    ```scala
    val numDynamicPartitions = partSpec.values.filter(_.isEmpty).size
    val numStaticPartitions = partSpec.values.filter(_.isDefined).size)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to