Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2226#issuecomment-54911724
Thanks again for working on this! This will be an awesome feature to have.
:) I did a pretty detailed pass and made a few comments. A few high-level
notes:
- There was a lot of unnecessary mutable state, which we try to avoid in
Spark SQL. In general we try to limit the use of `vars` to places where it is
critical for performance.
- If at all possible it would be great to separate the dynamic partition
support from the rest of the code. Right now there are a lot of `if
(dynamicPartNum == 0)` or `if (record._2 == null)` or `if (dynamicPartNum > 0)`
checks interleaved with other code. I think this might be a little easier to
follow if common code was broken out into functions and there was a single path
for each type of insertion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
