Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1612#discussion_r17279150
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/JdbcRDD.scala ---
    @@ -81,8 +113,14 @@ class JdbcRDD[T: ClassTag](
           logInfo("statement fetch size set to: " + stmt.getFetchSize + " to 
force MySQL streaming ")
         }
     
    -    stmt.setLong(1, part.lower)
    -    stmt.setLong(2, part.upper)
    +    val parameterCount = stmt.getParameterMetaData.getParameterCount
    +    if (parameterCount > 0) {
    --- End diff --
    
    Yeah, I agree.  I was annoyed when I had to work around this.  As long as 
its backwards compatible I'm okay including it here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to