Github user koeninger commented on a diff in the pull request:
https://github.com/apache/spark/pull/1612#discussion_r17279806
--- Diff: core/src/main/scala/org/apache/spark/rdd/JdbcRDD.scala ---
@@ -81,8 +113,14 @@ class JdbcRDD[T: ClassTag](
logInfo("statement fetch size set to: " + stmt.getFetchSize + " to
force MySQL streaming ")
}
- stmt.setLong(1, part.lower)
- stmt.setLong(2, part.upper)
+ val parameterCount = stmt.getParameterMetaData.getParameterCount
+ if (parameterCount > 0) {
--- End diff --
Not that there's anything wrong with backwards compatible
fixes/enhancements, but a few things I noticed here:
1. If it's a sufficiently small table that a user is only using 1
partition, why not encourage them to query it from the driver and broadcast it?
2. As it stands, it looks like you allow 0, 1, 2, or more ? placeholders,
but the doc comment change only describes the 0 or 2 case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
