Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16589#discussion_r96285488
  
    --- Diff: R/pkg/R/install.R ---
    @@ -201,14 +221,20 @@ directDownloadTar <- function(mirrorUrl, version, 
hadoopVersion, packageName, pa
       msg <- sprintf(fmt, version, ifelse(hadoopVersion == "without", "Free 
build", hadoopVersion),
                      packageRemotePath)
       message(msg)
    -  downloadUrl(packageRemotePath, packageLocalPath, paste0("Fetch failed 
from ", mirrorUrl))
    +  downloadUrl(packageRemotePath, packageLocalPath)
    --- End diff --
    
    It's still there. Both messages `Fetch failed` and error message from 
`download.file` were there before.
    
    Before it is passing the url string several method calls deep, instead, I 
handle the error up in the stack and display the same message like in 
[here](https://github.com/apache/spark/pull/16589/files/9b21c1125998b09607dc40c57dcd579d322b6f6e#diff-48b5d60aba76122785461e1c2b125f51R121),
 and with url 
[here](https://github.com/apache/spark/pull/16589/files/9b21c1125998b09607dc40c57dcd579d322b6f6e#diff-48b5d60aba76122785461e1c2b125f51R176)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to