Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16589#discussion_r96569089
--- Diff: R/pkg/R/install.R ---
@@ -201,14 +221,20 @@ directDownloadTar <- function(mirrorUrl, version,
hadoopVersion, packageName, pa
msg <- sprintf(fmt, version, ifelse(hadoopVersion == "without", "Free
build", hadoopVersion),
packageRemotePath)
message(msg)
- downloadUrl(packageRemotePath, packageLocalPath, paste0("Fetch failed
from ", mirrorUrl))
+ downloadUrl(packageRemotePath, packageLocalPath)
--- End diff --
yea I agree. I guess I'm trying to bubble up error messages to the top
level but generally the exception to throw is making this non-trivial (never
thought I'd say that!)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
