Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r97219666
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -106,11 +148,24 @@ private[regression] trait
GeneralizedLinearRegressionBase extends PredictorParam
schema: StructType,
fitting: Boolean,
featuresDataType: DataType): StructType = {
- if (isDefined(link)) {
- require(supportedFamilyAndLinkPairs.contains(
- Family.fromName($(family)) -> Link.fromName($(link))),
"Generalized Linear Regression " +
- s"with ${$(family)} family does not support ${$(link)} link
function.")
+ if ($(family) == "tweedie") {
+ if (isSet(link)) {
+ logWarning("When family is tweedie, use param linkPower to specify
link function. " +
+ "Setting param link will take no effect.")
+ }
+ } else {
+ if (isSet(linkPower)) {
--- End diff --
Here we should add similar check for ```variancePower```, since when
```family != "tweedie"```, both ```variancePower``` and ```linkPower``` should
not be set.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
