Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r97218693
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -369,6 +446,23 @@ object GeneralizedLinearRegression extends
DefaultParamsReadable[GeneralizedLine
}
}
+ private[regression] object FamilyAndLink {
+
+ /**
+ * Constructs the FamilyAndLink object from a parameter map
+ */
+ def apply(params: GeneralizedLinearRegressionBase): FamilyAndLink = {
+ val familyObj = Family.fromParams(params)
+ val linkObj = if ((params.getFamily != "tweedie" &&
params.isDefined(params.link)) ||
--- End diff --
```isSet``` is more accurate than ```isDefined``` at here, since there is
always no default values for both of them. I knew the original code used
```isDefined```, but it's better we can correct them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
