Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16670#discussion_r97393450
--- Diff: R/pkg/inst/tests/testthat/test_Windows.R ---
@@ -20,7 +20,7 @@ test_that("sparkJars tag in SparkContext", {
if (.Platform$OS.type != "windows") {
skip("This test is only for Windows, skipped")
}
- testOutput <- launchScript("ECHO", "a/b/c", capture = TRUE)
+ testOutput <- launchScript("ECHO", "a/b/c", wait = TRUE)
--- End diff --
From what I observed running SparkR as a package, I'm not sure we should
pipe/redirect the stdout always - it could get very noisy running SparkR from
an IDE. On the other hand, often times the result (error) is not enough to
debug the issue.
I'd propose we don't redirect stdout by default in keeping the IDE
experience cleaner, however we should have an API to "turn this on and off"
programmatically on demand. Although it is not clear `system2` supports that
though, stdout is either TRUE (capture to return as a character vector),
NULL/FALSE (drop), "" (to the console *of that child process*), "name" (file
name of the stdout getting logged into)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
