Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/16670#discussion_r98264755
--- Diff: R/pkg/inst/tests/testthat/test_Windows.R ---
@@ -20,7 +20,7 @@ test_that("sparkJars tag in SparkContext", {
if (.Platform$OS.type != "windows") {
skip("This test is only for Windows, skipped")
}
- testOutput <- launchScript("ECHO", "a/b/c", capture = TRUE)
+ testOutput <- launchScript("ECHO", "a/b/c", wait = TRUE)
--- End diff --
I think the second option is fine - i.e not redirecting it by default but
happening to share stdout with the R process. That way if say the R IDE has
some way to save or view logs from the stdout of R, then users can use that
(Does RStudio have something like this ?)
The API to redirect on demand might be useful (it'll be something like
setLogLevel ?) but I'm not sure we can change it for an already running JVM ?
Anyways let me review this PR one more time, I think we can discuss the
new API in a separate JIRA
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
