Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/16650#discussion_r97877539
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala ---
@@ -173,6 +174,24 @@ private[scheduler] class BlacklistTracker (
listenerBus.post(SparkListenerExecutorBlacklisted(now, exec,
newTotal))
executorIdToFailureList.remove(exec)
updateNextExpiryTime()
+ // Add executor to blacklist before attempting to kill it. This
allows a scheduler backend
+ // to immediately fail to allocate resources on this executor,
since killing could be
+ // asynchronous.
--- End diff --
This comment is only needed above the nodeBlacklist case. Each executor ID
is always unique, so we dont' need to worry about the cluster manager
registering the same executor again.
Also, I think "allows ... to fail" is a little confusing. How about "This
is so the scheduler backend can reject any additional resources the cluster
manager gives on the blacklisted node."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
