Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16650#discussion_r97890113
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationClient.scala ---
@@ -59,6 +59,19 @@ private[spark] trait ExecutorAllocationClient {
def killExecutors(executorIds: Seq[String]): Seq[String]
/**
+ * Request that the cluster manager try harder to kill the specified
executors,
+ * and maybe replace them.
+ * @return whether the request is acknowledged by the cluster manager.
+ */
+ def killExecutors(executorIds: Seq[String], replace: Boolean, force:
Boolean): Seq[String]
--- End diff --
I wonder if it's not better to just change the existing method to have the
extra arguments with default values. I see only a handful of calls to the 1-arg
version, so maybe even forcing all of them to pass all arguments would be ok.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
