Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/16536#discussion_r97907785
--- Diff: python/pyspark/sql/tests.py ---
@@ -459,6 +459,23 @@ def filename(path):
row2 = df2.select(sameText(df2['file'])).first()
self.assertTrue(row2[0].find("people.json") != -1)
+ def test_udf_defers_judf_initalization(self):
--- End diff --
This seems like a good test but maybe a bit too focused on testing the
implementation specifics?
Maybe it might more sense to also have a test which verifies creating a UDF
doesn't create a SparkSession since that is the intended purposes (we don't
really care about delaying the initialization of _judfy that much per-se but we
do care about verifying that we don't eagerly create the SparkSession on
import). What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
