Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/16536#discussion_r97910321
--- Diff: python/pyspark/sql/functions.py ---
@@ -1826,19 +1826,27 @@ class UserDefinedFunction(object):
def __init__(self, func, returnType, name=None):
self.func = func
self.returnType = returnType
- self._judf = self._create_judf(name)
-
- def _create_judf(self, name):
+ self._judf_placeholder = None
+ self._name = name or (
+ func.__name__ if hasattr(func, '__name__')
+ else func.__class__.__name__)
+
+ @property
+ def _judf(self):
+ if self._judf_placeholder is None:
--- End diff --
So there isn't any lock around this - I suspect we aren't too likely to
have concurrent calls to this - but just to be safe we should maybe think
through what would happen if this is does happen (and then leave a comment
about it)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
