Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16729#discussion_r98341000
--- Diff: R/pkg/R/mllib_regression.R ---
@@ -109,7 +125,8 @@ setMethod("spark.glm", signature(data =
"SparkDataFrame", formula = "formula"),
# For known families, Gamma is upper-cased
jobj <-
callJStatic("org.apache.spark.ml.r.GeneralizedLinearRegressionWrapper",
"fit", formula, data@sdf,
tolower(family$family), family$link,
- tol, as.integer(maxIter),
as.character(weightCol), regParam)
+ tol, as.integer(maxIter),
as.character(weightCol), regParam,
+ as.double(variancePower),
as.double(linkPower))
--- End diff --
we probably don't need to `as.double` here since it is either set to fixed
values (L116) or from a calculation. Instead, we should check `var.power` and
`link.power` are within the correct range - not sure if the tweedie function
does that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
