Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16729#discussion_r98341289
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/r/GeneralizedLinearRegressionWrapper.scala
---
@@ -143,7 +150,12 @@ private[r] object GeneralizedLinearRegressionWrapper
val rDeviance: Double = summary.deviance
val rResidualDegreeOfFreedomNull: Long =
summary.residualDegreeOfFreedomNull
val rResidualDegreeOfFreedom: Long = summary.residualDegreeOfFreedom
- val rAic: Double = summary.aic
+ val rAic: Double = if (family.toLowerCase == "tweedie" &&
+ !Array(0.0, 1.0, 2.0).contains(variancePower)) {
--- End diff --
we are comparing double values here, do you know how reliable is this?
should it have epsilon in the comparison?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
