Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16269#discussion_r99397097
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ddl.scala ---
    @@ -20,15 +20,23 @@ package org.apache.spark.sql.execution.datasources
     import org.apache.spark.sql._
     import org.apache.spark.sql.catalyst.TableIdentifier
     import org.apache.spark.sql.catalyst.catalog.{CatalogTable, CatalogUtils}
    -import org.apache.spark.sql.catalyst.plans.QueryPlan
    -import org.apache.spark.sql.catalyst.plans.logical.{Command, LogicalPlan}
    +import org.apache.spark.sql.catalyst.expressions.Attribute
    +import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan
     import org.apache.spark.sql.execution.command.{DDLUtils, RunnableCommand}
     import org.apache.spark.sql.types._
     
    +/**
    + * Create a table and optionally insert some data into it. Note that this 
plan is unresolved and
    + * has to be replaced by the concrete implementations during analyse.
    --- End diff --
    
    To the other reviewers, `CreateTable` is a unified unresolved logical 
representation of CREATE TABLE (AS SELECT). It will be replaced by 
`CreateHiveTableAsSelectCommand`, `CreateTableCommand`, 
`CreateDataSourceTableCommand` or `CreateDataSourceTableAsSelectCommand`.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to