Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16269#discussion_r99401502
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala ---
@@ -80,13 +80,17 @@ class DetermineHiveSerde(conf: SQLConf) extends
Rule[LogicalPlan] {
/**
* Replaces generic operations with specific variants that are designed to
work with Hive.
*
- * Note that, this rule must be run after `PreprocessTableInsertion`.
+ * Note that, this rule must be run after `PreprocessTableCreation` and
+ * `PreprocessTableInsertion`.
--- End diff --
Could you also add two more rules `OrcConversions` and
`ParquetConversions`? `HiveAnalysis` must be run after them too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
