Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/16844#discussion_r100385423
--- Diff:
core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -695,11 +690,16 @@ public boolean append(Object kbase, long koff, int
klen, Object vbase, long voff
assert (vlen % 8 == 0);
assert (longArray != null);
- if (numKeys == MAX_CAPACITY
- // The map could be reused from last spill (because of no enough
memory to grow),
- // then we don't try to grow again if hit the `growthThreshold`.
- || !canGrowArray && numKeys > growthThreshold) {
- return false;
+ if (numKeys >= growthThreshold) {
+ if (longArray.size() / 2 == MAX_CAPACITY) {
--- End diff --
@davies You are right that the check for `longArray.size() / 2 ==
MAX_CAPACITY` is the upper bound beyond which we cant grow. It is simply
confusing it do it outside growAndRehash - which is what threw me off.
Please move the check into growAndRehash() and have it return true in case
it could successfully grow the map.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
