Github user actuaryzhang commented on the issue:

    https://github.com/apache/spark/pull/16699
  
    @sethah @imatiach-msft 
    
    Please review the new commit. Main changes:
    - Fix issue in null deviance calculation in the presence of offset. Except 
for special cases (Gaussian with identity link), we need to re-estimate a 
intercept only model. The discussions in #16740 are indeed very helpful here. 
    - Updated the test for weighted GLM to include offset as well in order to 
test the addition of offset thoroughly. 
    
    Please let me know if there is any issue. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to