Github user sethah commented on the issue:

    https://github.com/apache/spark/pull/16699
  
    Ah, thank you very much for that clarification, I don't have much 
experience using R. I tried this out earlier, and it seems you have to use the 
same offset column name as you show above. I apologize for not making my 
intentions clear earlier - I wanted to discuss the R behavior to make sure we 
were doing the right thing here. 
    
    We actually discuss R's behavior a lot and even use it as a baseline for 
our unit tests, as you know. I think being able to compare new Spark PRs to 
other packages enables reviewers who may not be experts in a particular area to 
still contribute. More importantly, since it takes quite a lot of time and 
effort to do code review I like to make sure we have decided on the high-level 
approach before spending time on implementation details, which I find saves 
time in the long run. JMO, hope it makes sense :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to